Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mainline Rebar (v2) #1678

Closed
wants to merge 1 commit into from

Conversation

lag-linaro
Copy link
Contributor

This PR uses the latest software provided by the upstream Rebar (v2) repo.

The most significant change allows this version of Rebar to work with compilers which do not support the -m64 flag, as reported in #892 amongst others.

The latest code base also contains @davisp's Properly skip apps with a .app.src.script file patch with CouchDB has been carrying for a while now.

Signed-off-by: Lee Jones lee.jones@linaro.org

Signed-off-by: Lee Jones <lee.jones@linaro.org>
@wohali
Copy link
Member

wohali commented Oct 24, 2018

Unfortunately, we cannot accept this PR, as none of our dependencies can be on repositories outside of the Apache organization directly.

You can try a PR against the apache/couchdb-rebar repository if you want...

Sorry about this.

@wohali wohali closed this Oct 24, 2018
@wohali
Copy link
Member

wohali commented Oct 24, 2018

Also, we have a strong preference to migrate the build process to rebar 3 - #1428. If you are able to help with this conversion process, we'll be especially grateful.

@lag-linaro
Copy link
Contributor Author

Unfortunately, we cannot accept this PR, as none of our dependencies can be on repositories outside of the Apache organization directly.

You can try a PR against the apache/couchdb-rebar repository if you want...

Sorry about this.

That's okay. I will update CouchDB's Rebar repo instead.

@lag-linaro
Copy link
Contributor Author

lag-linaro commented Oct 25, 2018

Also, we have a strong preference to migrate the build process to rebar 3 - #1428. If you are able to help with this conversion process, we'll be especially grateful.

Yes, I am aware of that, and I'm happy to help.

NB: I would still like to see Rebar v2 updated in the mean time please.

I did briefly investigate moving to Rebar3, but I didn't find the code to update.

How does one compile native code with @davisp's offering? Where is the NIF code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants